[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r37048 - in trunk/subversion: libsvn_client libsvn_ra_neon libsvn_repos mod_dav_svn mod_dav_svn/reports svn svnserve

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 7 Apr 2009 13:36:19 +0200

On Tue, Apr 7, 2009 at 09:17, Senthil Kumaran S <senthil_at_collab.net> wrote:
>...
> +++ trunk/subversion/libsvn_client/copy.c       Tue Apr  7 00:17:08 2009        (r37048)
> @@ -1713,7 +1713,7 @@ try_copy(svn_commit_info_t **commit_info
>                                             src_is_url,
>                                             TRUE,
>                                             iterpool));
> -          src_basename = svn_path_basename(pair->src, iterpool);
> +          src_basename = svn_uri_basename(pair->src, iterpool);
>           if (srcs_are_urls && ! dst_is_url)
>             src_basename = svn_path_uri_decode(src_basename, iterpool);
>
> @@ -1993,7 +1993,7 @@ svn_client_copy5(svn_commit_info_t **com
>       svn_error_clear(err);
>       svn_pool_clear(subpool);
>
> -      src_basename = svn_path_basename(src_path, subpool);
> +      src_basename = svn_uri_basename(src_path, subpool);
>       if (svn_path_is_url(src_path) && ! svn_path_is_url(dst_path))
>         src_basename = svn_path_uri_decode(src_basename, subpool);
>
> @@ -2080,7 +2080,7 @@ svn_client_move5(svn_commit_info_t **com
>       svn_error_clear(err);
>       svn_pool_clear(subpool);
>
> -      src_basename = svn_path_basename(src_path, pool);
> +      src_basename = svn_uri_basename(src_path, pool);
>
>       err = try_copy(&commit_info, sources,
>                      svn_path_join(dst_path, src_basename, pool),

In the three cases above, the src value might be a dirent *or* a URI.

I'm not sure if the above works in all cases, or whether more care is
needed. Bert?

>...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1576118
Received on 2009-04-07 13:36:41 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.