On Fri, Apr 03, 2009 at 05:17:24PM +0800, Edmund Wong wrote:
> Hi Stefan,
>
> >
> > Yes. Give it a shot if you want to.
> >
>
> Pardon my ignorance, but which .c file does this issue
> pertain to? I'm looking at notify.c but it doesn't
> look like the right one and tree-conflicts.c doesn't
> look like it either.
>
> Thanks for the help.
It won't be a single file :)
Basically, conflict stat gathering needs to be moved into
the client library, and be done per-operation. Users of the
client library should be able to receive conflict stats as
part of the result of an API call such as svn_client_update().
Right now, the conflict stats are gathered purely inside
the command line client, based on notifications received
from the client library. This is a bit of a hack, and cannot
easily be made as accurate as we'd like it to be, hence issue #3342.
Pushing this down into the client library would also benefit
other clients such as TortoiseSVN.
If you feel this is too overwhelming, don't rush into it.
Just keep fixing simple problems like you did for issue #3207.
Doing this really helps the project, and you will gain more
confidence and learn more about the code as you go along.
The amount of problems that need to be fixed is really large anyway.
There should be many little problems that need little fixes.
If you still decide to go for fixing the conflict stats,
expect to invest some time. And feel free to ask questions,
of course.
Most importantly, just do what is fun!
Stefan
Received on 2009-04-04 14:57:08 CEST