[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: diff_tests 4 and wc-ng

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: Wed, 1 Apr 2009 16:19:23 +0200

On Wed, Apr 1, 2009 at 4:02 PM, Greg Stein <gstein_at_gmail.com> wrote:
> From my investigation, it looked like we need to mark child nodes of a
> copied subtree that is now schedule-delete as both schedule-delete and
> copied. We were not marking them copied.
>
> In any case, I just confirmed the same text_time/mtime race in wc-1
> when I disabled the size check. Eesh.

Isn't this an issue because we have the "wait for timestamps" disabled
when running the test suite? Under normal operation, you would not see
the situation with "no time difference" because it would wait for
timestamps.

Basically, the test depends on the file size to be changed for the
test to succeed. I don't think it's the only one.

> Basically: if altered the test to create a "new rho" with a file of
> the *same length*, then it would sporadically fail, even within wc-1.
> The human description would be "replace a file with something of the
> same length; svn diff may not show any differences."

But only if it has the same length *and* the same timestamp, right?

Bye,

Erik.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1507462
Received on 2009-04-01 16:19:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.