Re: [PATCH] change-svn-wc-format.py

On Mon, 30 Mar 2009 14:22:30 +0100, Stefan Sperling wrote
> Don't worry! I appreciate you stubbornness to get this
> done properly :)
>
Stubbornness is my middle name. Actually, not really. :)
 
> >
> > (class Format): Added new class to take
>
> You don't need to mention the type of the things in parens,
> i.e. just saying "(Format): New class to take ..." etc. is enough.

Oh. Ok.

>
> > care of the .svn/format file.
> >
> > Patch by: Edmund Wong <edmund_at_belfordhk.com>
> > Reviewed by: stsp <stsp_at_elego.de>
> > arfrever <arfrever_at_gentoo.org>
> > Daniel Shahaf <d.s_at_daniel.shahaf.name>
>
> All reviewers are committers (listed in trunk/COMMITTERS).
> For committers, the tigris.org account name is enough.
>
> Reviewed by: stsp
> arfrever
> danielsh

Understood.

>
> > Index: change-svn-wc-format.py
> > ===================================================================
> > --- change-svn-wc-format.py (revision 36847)
> > +++ change-svn-wc-format.py (working copy)
> > @@ -84,7 +84,7 @@
> > if self.verbosity:
> > print("Processing directory '%s'" % dirname)
> > entries = Entries(os.path.join(dirname, get_adm_dir(), "entries"))
> > -
> > + entries_parsed = True
>
> The indentation of the line above seems to be off by one character.
> Won't python complain about this?

I don't understand. I thought it was aligned properly when
I posted it. I'll check it again.

> This seems to be off by one char again (maybe something weird
> happened to the mail you sent???):
>
I'm getting the same feeling too. I'll recheck the patch and
...send it again. *scratches head*
 
Edmund

--
"Pax tecum"
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1482424