[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

questionable code?

From: Matthew Woehlke <mw_triad_at_users.sourceforge.net>
Date: Wed, 25 Mar 2009 15:20:42 -0500

In find_unmerged_mergeinfo (subversion/libsvn_client/merge.c circa line
7490), the line near the bottom of the function:
   if (SVN_IS_VALID_REVNUM(youngest_merged_rev))

...causes a compile error on c89 compilers. It looks like this line
should actually be:
   if (SVN_IS_VALID_REVNUM(*youngest_merged_rev))

(Noticed in 1.5.6 and 1.6.0.)

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
"Yoda of Borg am I. Futile is resistance. Assimilate you, I will."
   -- from http://en.wikipedia.org/wiki/Wikipedia:Yet_more_Best_of_BJAODN
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1419692
Received on 2009-03-25 21:40:43 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.