[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r36747 - trunk/subversion/libsvn_subr

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Wed, 25 Mar 2009 00:05:30 +0100

> -----Original Message-----
> From: Greg Stein [mailto:gstein_at_gmail.com]
> Sent: Tuesday, March 24, 2009 11:18 PM
> To: dev_at_subversion.tigris.org
> Subject: Re: svn commit: r36747 - trunk/subversion/libsvn_subr
>
> I think the change is fine. "Knowing" that a close is a no-op implies
> knowing the implementation, rather than the abstraction.
>
> If you can demonstrate this close is a problem (e.g. performance),
> then we can eliminate it, leaving a comment in place to explain the
> situation.

No.. I just read it as a no-op that didn't need backporting.. But rechecking the code I found the reason that it needs the close. (The second wrapping of the stream).

I'll add my +1 on the backport nomination.

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1406948
Received on 2009-03-25 00:05:59 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.