[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r36383 - in trunk/subversion: libsvn_subr tests/libsvn_subr

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 7 Mar 2009 14:15:15 +0100

On Sat, Mar 7, 2009 at 13:34, Bert Huijben <rhuijben_at_sharpsvn.net> wrote:
>...
> @@ -932,6 +933,15 @@ test_dirent_is_canonical(const char **ms
>                                  tests[i].path,
>                                  canonical ? "TRUE" : "FALSE",
>                                  tests[i].canonical ? "TRUE" : "FALSE");
> +
> +      canonicalized = svn_dirent_canonicalize(tests[i].path, pool);
> +
> +      if (canonical && (strcmp(tests[i].path, canonicalized) != 0))
> +        return svn_error_createf(SVN_ERR_TEST_FAILED, NULL,
>...
> @@ -1035,6 +1049,16 @@ test_uri_is_canonical(const char **msg,
>                                  tests[i].path,
>                                  canonical ? "TRUE" : "FALSE",
>                                  tests[i].canonical ? "TRUE" : "FALSE");
> +
> +      canonicalized = svn_uri_canonicalize(tests[i].path, pool);
> +
> +      if (canonical != (strcmp(tests[i].path, canonicalized) == 0))
> +        return svn_error_createf(SVN_ERR_TEST_FAILED, NULL,

Why are these two checks different?

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1282703
Received on 2009-03-07 14:15:44 CET

This is an archived mail posted to the Subversion Dev mailing list.