Re: svn commit: r36363 - trunk/subversion/libsvn_ra_serf

On Fri, Mar 6, 2009 at 12:29 PM, Greg Stein <gstein_at_gmail.com> wrote:
> Geez... making a duplicate to satisfy a const warning? That is *not*
> the right approach.
>
> Instead, you can easily see that the handler is not attempting to
> modify the header at all. It should have been declared as a const
> parameter. *That* is the proper change.

Agreed.

>
> I sent lgo a review of the auth work yesterday, but he may have missed
> it. That included adding a lot of const qualifiers.
>
> I'll take care of it. This kind of change is just silly.
>
> -g

I didn't miss it Greg, just didn't have the time yet to work on your
suggestions. I'll do it this weekend, no need to do it yourself.

Lieven

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1277243
Received on 2009-03-06 14:16:44 CET