[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r36363 - trunk/subversion/libsvn_ra_serf

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 6 Mar 2009 12:29:00 +0100

Geez... making a duplicate to satisfy a const warning? That is *not*
the right approach.

Instead, you can easily see that the handler is not attempting to
modify the header at all. It should have been declared as a const
parameter. *That* is the proper change.

I sent lgo a review of the auth work yesterday, but he may have missed
it. That included adding a lot of const qualifiers.

I'll take care of it. This kind of change is just silly.

-g

On Fri, Mar 6, 2009 at 08:25, Senthil Kumaran S <senthil_at_collab.net> wrote:
> Author: stylesen
> Date: Thu Mar  5 23:25:44 2009
> New Revision: 36363
>
> Log:
> Follow up r36331.
>
> Fix compiler warning of 'passing argument discards qualifiers from pointer
> target type'.
>
> * subversion/libsvn_ra_serf/auth.c
>  (handle_auth_header): Pass 'char *' header instead of 'const char *'.
>
> Modified:
>   trunk/subversion/libsvn_ra_serf/auth.c
>
> Modified: trunk/subversion/libsvn_ra_serf/auth.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra_serf/auth.c?pathrev=36363&r1=36362&r2=36363
> ==============================================================================
> --- trunk/subversion/libsvn_ra_serf/auth.c      Thu Mar  5 20:36:58 2009        (r36362)
> +++ trunk/subversion/libsvn_ra_serf/auth.c      Thu Mar  5 23:25:44 2009        (r36363)
> @@ -197,7 +197,7 @@ handle_auth_header(void *baton,
>   if (strcmp(key, auth_hdr) != 0)
>     return 0;
>
> -  auth_name = apr_strtok(header, " ", &auth_attr);
> +  auth_name = apr_strtok(apr_pstrdup(ab->pool, header), " ", &auth_attr);
>   ab->last_prot_name = auth_name;
>
>   /* Find the matching authentication handler.
> @@ -235,7 +235,8 @@ handle_auth_header(void *baton,
>              proto_found = TRUE;
>              ab->prot = prot;
>              err = handler(ab->ctx, ab->request, ab->response,
> -                           header, auth_attr, session->pool);
> +                           apr_pstrdup(ab->pool, header), auth_attr,
> +                            session->pool);
>            }
>          if (err)
>            {
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=1275824
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1276686
Received on 2009-03-06 12:29:18 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.