[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r36214 - in branches/1.6.x: . subversion/svn

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 5 Mar 2009 21:25:58 +0100

On Thu, Mar 5, 2009 at 20:10, Stefan Sperling <stsp_at_elego.de> wrote:
> On Mon, Mar 02, 2009 at 11:18:11AM +0000, Stefan Sperling wrote:
>> On Sun, Mar 01, 2009 at 08:15:59AM -0800, Justin Erenkrantz wrote:
>> > On Sun, Mar 1, 2009 at 8:08 AM, Greg Stein <gstein_at_gmail.com> wrote:
>> > > The release branch is about *stabilization*, and that process is under
>> > > the sole guidance of the Release Manager. That is *why* we have a
>> > > release manager. We cannot allow people to simply commit whatever they
>> > > feel is "obvious" to a branch that we are stabilizing for release. If
>> > > it is obvious, then it will get voted on and merged.
>> >
>> > +1.
>> >
>> > One person's obvious fix is another person's "wait a sec, I need to
>> > review" patch.  -- justin
>>
>> Fair enough. If a fix is obvious, it's more than likely going to
>> gather enough votes quickly anyway.
>
> Right guys, the thing is in STATUS now as per your request, so please vote
> on it if you have the time.
>
> It's an obvious fix and I'd like to get it into rc4.

IMO, it is *not* an obvious fix. In order to verify its correctness, I
would have to get a WC into a tree-conflicted state and then run 'svn
status' to verify the output.

Obvious fixes are typos, docstring updates, whitespace changes, or
other tweaks that don't affect the code or its output.

Look through the logs for other cases of "obvious fixes". They are
quite a bit different.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1273625
Received on 2009-03-05 21:26:35 CET

This is an archived mail posted to the Subversion Dev mailing list.