Re: svn commit: r36325 - trunk/subversion/libsvn_repos

On Wed, Mar 4, 2009 at 21:22, Bert Huijben <rhuijben_at_sharpsvn.net> wrote:
> Author: rhuijben
> Date: Wed Mar  4 12:22:11 2009
> New Revision: 36325
>
> Log:
> * subversion/libsvn_repos/repos.c
>  (svn_repos_find_root_path): Resolve endless loop on not absolute path.
>    Reproducable on windows with svn log file:///nonexistant. (basic_tests 20)

Why did the previous algorithm fail? Shouldn't "test for is_root"
work? I'm worried that this change is simply working around a bug, and
solving a symptom.

>...
> +++ trunk/subversion/libsvn_repos/repos.c       Wed Mar  4 12:22:11 2009        (r36325)
> @@ -1359,6 +1359,7 @@ svn_repos_find_root_path(const char *pat
>
>   while (1)
>     {
> +      char *parent;
>       /* Try to decode the path, so we don't fail if it contains characters

const on that, so that it doesn't seem like you're going to try and
modify it. And a blank line is always nice :-)

>...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1272143
Received on 2009-03-05 14:27:10 CET