[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] build/transform_sql.sh fails in Solaris with "Bad string" error

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 4 Mar 2009 12:08:19 +0000

On Wed, Mar 04, 2009 at 12:39:20PM +0530, Alexander Thomas wrote:
> When tried to build Subversion in Solaris, build/transform_sql shell
> script fails with a "Bad String" error and resultant
> libsvn_fs_fs/rep-cache-db.sql.h file generated with a empty macro name
> for #define.
>
> 'tr "[:lower:]" "[:upper:]"' command seems to fail in Solaris,
> especially when set with broken locale.
>
>
> [[[
> Solaris 'tr' fails to handle "[:lower:]" "[:upper:]", for a broken
> locale.
>
> * build/transform_sql.sh
> 'tr "[:lower:]" and "[:upper:]"' replaced with 'tr "[a-z]" "[A-Z]"'
> to address "Bad String" error in Solaris.
>
> ]]]
>
>
> -AT

Thanks, committed in r36300 and nominated for backport to 1.6.x in r36301.

Stefan

>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1265473
> Index: build/transform_sql.sh
> ===================================================================
> --- build/transform_sql.sh (revision 36298)
> +++ build/transform_sql.sh (working copy)
> @@ -1,6 +1,6 @@
> #!/bin/sh
>
> -varname=`basename $1 | tr "[:lower:]" "[:upper:]" | tr "-" "_" | tr "." "_"`
> +varname=`basename $1 | tr "[a-z]" "[A-Z]" | tr "-" "_" | tr "." "_"`
>
> echo "/* This file is automatically generated from"
> echo " * $1"
Received on 2009-03-04 13:38:13 CET

This is an archived mail posted to the Subversion Dev mailing list.