Gavin Baumanis wrote on Mon, 2 Mar 2009 at 23:49 +1100:
> A patch is proposed that is deemed to be of a benefit to the
> subversion project - but is hamstrung from being fully welcomed /
> supported because it doesn't meet appropriate use-case tests.
>
> Eg. "this"patch is useful only for Windows users.
>
On links.html this is quite acceptable (as Daniel Doubrovkine pointed
out). We have Mac-only clients, pay-only clients, etc., there.
> So in the sense of my patch manager role is there anything more that I
> can do?
> an example might be to request some "other" people have a look at the
> patch proposal - specifically looking at the mentioned shortfalls - so
> that a "complete" patch might be created.
>
Yes. Pointing out specific issues that stand in the way of the patch to
be applied is one way you (as patch manager) can advance the discussion.
(Just screaming "Ping!" repeatedly and threatening to archive a patch in
the tracker usually won't be as effective. :-))
This is equally true for technical issues (bugs in the code: e.g., not
portable) and formal issues (bugs in the submission: e.g., not sent as
a unidiff) --- fixing issues of either kind makes the committer's life
easier when he comes to apply the patch.
> or,
>
> Is it simply a case of - we're all volunteers (primarily) so if
> someone wants to make a *nix version of the patch they will - and in
> the meantime the OP is more than supported by the group providing
> assistance peer-review / assistance in patching their own installs and
> thus there is nothing more for me to do, aside from checking if there
> is any life left in the patch proposal?
>
I don't understand the question. If we asked the OP to make some
changes (e.g.: fix a portability bug) and resubmit the patch, and he
hasn't, you can ping the thread and ask for an update. Is that what you
asked?
> Afterall, - the mailing list serves as an archive should someone else
> on Windows have the same requirement - or a *nix coder wish to create
> a non-windows version of the patch?
>
Patches can also be archived in the issue tracker. (In general, where
there's already an issue, the patch should always be linked from it.)
Daniel
>
> Thanks.
>
> Beau.
>
> On 26/02/2009, at 5:45 AM, Daniel Doubrovkine wrote:
>
> >
> >
> >
> >
> > -dB.
> >
> > dblock.org / foodcandy.com
> >
> >
> >
> > <svn2svn.patch>
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1256168
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1258343
Received on 2009-03-02 22:25:58 CET