[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35510 - branches/explore-wc/subversion/libsvn_wc

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Fri, 13 Feb 2009 21:39:51 -0600

On Feb 13, 2009, at 8:45 PM, Greg Stein wrote:

> On Tue, Jan 27, 2009 at 22:50, Hyrum K. Wright
> <hyrum_at_hyrumwright.org> wrote:
>> ...
>> @@ -1981,7 +1987,39 @@ insert_actual_node(svn_sqlite__db_t *wc_
>> db_actual_node_t *actual_node,
>> apr_pool_t *scratch_pool)
>> {
>> - return SVN_NO_ERROR;
>> + svn_sqlite__stmt_t *stmt;
>> + svn_stringbuf_t *properties;
>> + svn_skel_t *skel;
>
> const on PROPERTIES and SKEL ?

Updated properties, but svn_skel__unparse_proplist() complains on a
const skel.

>> ...
>> @@ -2021,6 +2059,42 @@ write_entry(svn_stringbuf_t *buf,
>> ...
>> + if (entry->incomplete)
>> + {
>> + base_node = MAYBE_ALLOC(base_node, scratch_pool);
>> + /* TODO: how do we find the exact number of incomplete
>> children? */
>> + base_node->incomplete_children = 1;
>
> Answer: we don't. That was intended to be a boolean value.
> (wc-metadata.sql needs clarification)

Noticed you already did that on trunk. I've updated entries.c on
explore-wc in r35869.

> Maybe it should be a count? But I think we simply need a boolean to
> indicate "not ready; tread carefully".

Yeah, that's what I figured it meant. I don't think we need a count
here, and as the original question mentioned, I don't think we have a
readily available way of calculating it.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1155073
Received on 2009-02-14 04:40:08 CET

This is an archived mail posted to the Subversion Dev mailing list.