On Fri, Feb 6, 2009 at 18:40, Bert Huijben <rhuijben_at_sharpsvn.net> wrote:
> Author: rhuijben
> Date: Fri Feb 6 18:40:51 2009
> New Revision: 35731
>
> Log:
> Use a locale insensitive tolower and toupper when canonicalizing urls.
> Canonicalization should not depend on the active locale.
>...
> +++ trunk/subversion/libsvn_subr/dirent_uri.c Fri Feb 6 18:40:51 2009 (r35731)
> @@ -117,6 +117,27 @@ local_style(path_type_t type, const char
> return path;
> }
>
> +/* Locale insensitive tolower() for converting parts of dirents while
> + canonicalizing */
> +static char
> +dirent_to_lower(char c)
> +{
> + if (c < 'A' || c > 'Z')
> + return c;
> + else
> + return c - 'A' + 'a';
> +}
> +/* Locale insensitive toupper() for converting parts of dirents while
> + canonicalizing */
> +static char
> +dirent_to_upper(char c)
> +{
If these are intended to canonicalize URLs, then why use the prefix
"dirent_" ? The idea was "dirent" meant local filesystem paths, and
"url/uri" means URLs.
>...
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1125463
Received on 2009-02-08 21:30:12 CET