[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fwd: Possible bug in build-system

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 4 Feb 2009 00:02:54 +0000

On Tue, Feb 03, 2009 at 05:06:28PM -0600, Hyrum K. Wright wrote:
> Stefan Sperling wrote:
> > On Tue, Feb 03, 2009 at 03:06:15PM -0600, Hyrum K. Wright wrote:
> >> Julian Foad wrote:
> >>> Well, isn't the proper solution to use "make" to do this job, instead of
> >>> a manual step in "autogen"? (This is about re-making a target file from
> >>> a source file if it's out of date or doesn't yet exist, which is exactly
> >>> the purpose of "make".) Is there any reason this step needs to be done
> >>> so early in the build process?
> >> Not a deal breaker, but gen-make.py will complain if the referenced header file
> >> doesn't exist. That's why I put this step in autogen.sh before gen-make.py is run.
> >
> > So gen-make.py complains about something that is not a problem?
> > If so, making some fix to gen-make.py was not an option?
> >
> > I'd also think having make sort this stuff out, if at all possible,
> > is a better solution. It's more portable.
>
> One other caveat: the creation of the .h is currently done with a python script,
> but we don't require people who build Subversion to have python installed,
> though most probably do. I did it with python because it was easiest for me, if
> somebody with more sed/awk skillz wants to improve it, go ahead.

Would attached script do?

This is the output of transform_sql.py:

/* This file is automatically generated from rep-cache-db.sql.
 * Do not edit it directly, but edit the source file and rerun autogen.sh */

#define REP_CACHE_DB_SQL \
  "pragma auto_vacuum = 1;"\
  "create table rep_cache (hash text not null primary key,"\
  " revision integer not null,"\
  " offset integer not null,"\
  " size integer not null,"\
  " expanded_size integer not null);"\
  ""

This is the output from my script:

$ sh ./transform_sql.sh subversion/libsvn_fs_fs/rep-cache-db.sql < subversion/libsvn_fs_fs/rep-cache-db.sql
/* This file is automatically generated from
 * subversion/libsvn_fs_fs/rep-cache-db.sql
 * Do not edit it directly, but edit the source file
 * and rerun autogen.sh
 */

#define REP_CACHE_DB_SQL \
    "pragma auto_vacuum = 1;"\
    "create table rep_cache (hash text not null primary key,"\
    "revision integer not null,"\
    "offset integer not null,"\
    "size integer not null,"\
    "expanded_size integer not null);"\
    ""

No idea why the tabs are being zapped, but doesn't make a
difference, does it?

Stefan

Received on 2009-02-04 01:03:34 CET

This is an archived mail posted to the Subversion Dev mailing list.