[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fwd: Possible bug in build-system

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Tue, 03 Feb 2009 09:38:03 -0600

Mark Phippard wrote:
> Forwarding from users@
>
>
> ---------- Forwarded message ----------
> From: Christian Fischer <Christian.Fischer_at_hood-group.com>
> Date: Tue, Feb 3, 2009 at 6:05 AM
> Subject: Possible bug in build-system
> To: users_at_subversion.tigris.org
>
>
> Hello all!
>
> I tried to co and compile the current subversion rev35640.
> While running autogen.sh I discovered an error regarding a missing file:
>
> WARNING: "rep-cache-db.sql.h" header not found, file
> subversion/libsvn_fs_fs/rep-cache.c
>
> As autogen.sh also ./configure does not fail explicitly. But make does.
> So I tried a earlier revision and isolated revision 35542 (42..hrhr) as
> first version throwing the error.
>
> BUT: You will never discover the bug, if you are updating your wc from
> an earlier version (and run autogen.sh before) - here is why:
> In autogen.sh those headerfile will be updated if the rep-cache-db.sql
> file has changed.
> Revisions =<35541 are also generating these header file - or simply
> running always the responsible python scripts. (see below)
>
> I added "if not existent" and now it works like a charm!
>
> Sincerely
> Christian Fischer
>
>
>
> Index: autogen.sh
> ===================================================================
> --- autogen.sh (revision 35541)
> +++ autogen.sh (revision 35542)
> @@ -112,7 +112,11 @@
> fi
>
> # Transform sql files into header files
> -$PYTHON build/transform_sql.py subversion/libsvn_fs_fs/rep-cache-db.sql
> +for file in subversion/libsvn_fs_fs/rep-cache-db.sql; do
> + if test $file -nt $file.h; then
> + $PYTHON build/transform_sql.py $file
> + fi
> +done
>
>
>
> Index: autogen.sh
> ===================================================================
> --- autogen.sh (revision 35640)
> +++ autogen.sh (working copy)
> @@ -113,7 +113,7 @@
>
> # Transform sql files into header files
> for file in subversion/libsvn_fs_fs/rep-cache-db.sql; do
> - if test $file -nt $file.h; then
> + if (test $file -nt $file.h) || !(test -e $file.h); then
> $PYTHON build/transform_sql.py $file
> fi
> done

What shell are you using? I did a fresh checkout from trunk, ran autogen.sh and
configure, and didn't have any problem. rep-cache.sql.h was created as expected.

That being said, it don't think that it hurts to have this patch included.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1097179
Received on 2009-02-03 16:38:28 CET

This is an archived mail posted to the Subversion Dev mailing list.