[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35605 - branches/http-protocol-v2/subversion/mod_dav_svn

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 31 Jan 2009 21:48:35 +0100

On Sat, Jan 31, 2009 at 07:54, Ben Collins-Sussman <sussman_at_red-bean.com> wrote:
> On Fri, Jan 30, 2009 at 6:31 PM, Greg Stein <gstein_at_gmail.com> wrote:
>> On Fri, Jan 30, 2009 at 23:51, Ben Collins-Sussman <sussman_at_red-bean.com> wrote:
>>>...
>>> +++ branches/http-protocol-v2/subversion/mod_dav_svn/repos.c Fri Jan 30 14:51:09 2009 (r35605)
>>> @@ -3953,6 +3953,34 @@ dav_svn__create_version_resource(dav_res
>>> }
>>>
>>>
>>> +/* POST handler for commits over HTTP protocol v2.
>>> +*/
>>> +int dav_svn__method_post(request_rec *r)
>>> +{
>>> + dav_resource *resource;
>>> + dav_error *derr;
>>> +
>>> + derr = get_resource(r, dav_svn__get_root_dir(r),
>>> + "ignored", 0, &resource);
>>> + if (derr != NULL)
>>> + return derr->status;
>>> +
>>> + if (resource->info->restype != DAV_SVN_RESTYPE_ME)
>>> + return HTTP_BAD_REQUEST;
>>> +
>>> + /* ### Create a new txn based on HEAD. Remember the UUID. */
>>> +
>>> + /* ### Build a 200 CREATED response with two special headers in it:
>>> +
>>> + !svn/txn/UUID
>>> + !svn/txp/UUID
>>> + */
>>
>> Eh? You don't want the (repository) UUID in there. That is implied by
>> the URL leading to *this* repository. You mean the "transaction ID".
>>
>
> Yes, that's what I meant too. In my own mind, I've overloaded the
> phrase "uuid" to mean both repository uuid and newly-created txn id.
> They both call the same apr_uuid() function, after all. :-)

Woah. Really? I didn't know the txn's were uuids. Cool.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1081709
Received on 2009-01-31 21:48:56 CET

This is an archived mail posted to the Subversion Dev mailing list.