[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Segfault in ruby tests

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: Sat, 31 Jan 2009 17:45:01 +0900 (JST)

Hi,

In <497F4B21.5030008_at_mail.utexas.edu>
  "Segfault in ruby tests" on Tue, 27 Jan 2009 11:57:53 -0600,
  "Hyrum K. Wright" <hyrum_wright_at_mail.utexas.edu> wrote:

> The ruby bindings tests are segfaulting on the buildbot. I can reproduce locally:

I don't know about the detail of the problem but this patch
will solve the problem:

Index: subversion/libsvn_delta/text_delta.c
===================================================================
--- subversion/libsvn_delta/text_delta.c (revision 35611)
+++ subversion/libsvn_delta/text_delta.c (working copy)
@@ -788,8 +788,11 @@
                                      apr_pool_t *pool)
 {
   svn_txdelta_stream_t *txstream;
+ apr_pool_t *sub_pool;
   svn_error_t *err;
 
+ sub_pool = svn_pool_create(pool);
+
   /* ### this is a hack. we should simply read from the stream, construct
      ### some windows, and pass those to the handler. there isn't any reason
      ### to crank up a full "diff" algorithm just to copy a stream.
@@ -798,8 +801,8 @@
 
   /* Create a delta stream which converts an *empty* bytestream into the
      target bytestream. */
- svn_txdelta(&txstream, svn_stream_empty(pool), stream, pool);
- err = svn_txdelta_send_txstream(txstream, handler, handler_baton, pool);
+ svn_txdelta(&txstream, svn_stream_empty(sub_pool), stream, sub_pool);
+ err = svn_txdelta_send_txstream(txstream, handler, handler_baton, sub_pool);
 
   if (digest && (! err))
     {
@@ -809,6 +812,8 @@
       memcpy(digest, result_md5, APR_MD5_DIGESTSIZE);
     }
 
+ svn_pool_destroy(sub_pool);
+
   return err;
 }
 

P.S.: I'm still busy... It will be continued at least a few
months... Please expect my response...

Thanks,

--
kou
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1079028
Received on 2009-01-31 09:45:28 CET

This is an archived mail posted to the Subversion Dev mailing list.