[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35535 - trunk/subversion/libsvn_subr

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Thu, 29 Jan 2009 07:40:57 -0800

Sorry, that was perhaps a bad choice of words. "Deprecated" is probably better.

Greg Stein wrote:
> Hunh? What method is unsupported?
>
> Those SQLite guys are pretty scary about their contracts around
> functions. If a function is "unsupported", then I doubt we'd want to
> rely on it for anything.
>
> Cheers,
> -g
>
> On Thu, Jan 29, 2009 at 02:19, Hyrum K. Wright <hyrum_at_hyrumwright.org> wrote:
>> Author: hwright
>> Date: Wed Jan 28 17:19:55 2009
>> New Revision: 35535
>>
>> Log:
>> Revert r35414 and r35403, which had to do with SQLite error handling.
>> Paradoxically, the errors returned by the "unsupported" method are much
>> more useful than those returns by the new way.
>>
>> Modified:
>> trunk/subversion/libsvn_subr/sqlite.c
>>
>> Modified: trunk/subversion/libsvn_subr/sqlite.c
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/sqlite.c?pathrev=35535&r1=35534&r2=35535
>> ==============================================================================
>> --- trunk/subversion/libsvn_subr/sqlite.c Wed Jan 28 17:11:26 2009 (r35534)
>> +++ trunk/subversion/libsvn_subr/sqlite.c Wed Jan 28 17:19:55 2009 (r35535)
>> @@ -185,13 +185,8 @@ svn_sqlite__step(svn_boolean_t *got_row,
>> int sqlite_result = sqlite3_step(stmt->s3stmt);
>>
>> if (sqlite_result != SQLITE_DONE && sqlite_result != SQLITE_ROW)
>> - {
>> - /* Create the error, then reset the statement, and return the error. */
>> - svn_error_t *err = svn_error_create(SQLITE_ERROR_CODE(sqlite_result),
>> - NULL, sqlite3_errmsg(stmt->db->db3));
>> - svn_error_clear(svn_sqlite__reset(stmt));
>> - return err;
>> - }
>> + /* Extract the real error value and reset the statement. */
>> + SVN_ERR(svn_sqlite__reset(stmt));
>>
>> *got_row = (sqlite_result == SQLITE_ROW);
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=1065767
>>
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1067818
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1069178
Received on 2009-01-29 16:41:17 CET

This is an archived mail posted to the Subversion Dev mailing list.