[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Wed, 28 Jan 2009 21:16:02 -0800

Daniel Shahaf wrote:
> Hyrum K. Wright wrote on Wed, 28 Jan 2009 at 15:15 -0800:
>> Greg Stein wrote:
>>> On Wed, Jan 28, 2009 at 20:48, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
>>>> On Fri, 23 Jan 2009 12:39 -0800, "Hyrum K. Wright"
>>>> <hyrum_at_hyrumwright.org> wrote:
>>>>> + case 'b':
>>>>> + SVN_ERR(svn_sqlite__bind_blob(stmt, count,
>>>>> + va_arg(ap, const void *),
>>>>> + va_arg(ap, apr_size_t)));
>>>>> + break;
>>>>> +
>>>> Can we use two va_arg() calls inside the function call? IIRC, the order
>>>> of evaluation of parameters to a function call is not defined...
>>> Agreed. I mentioned the same thing to Hyrum on IRC, but he either
>>> missed it, or labeled me a lunatic and ignored me. :-P
>> Let's just say I missed it and move along. :)
>
> Another thing Greg mentioned on IRC was the need to add parentheses
> around the definition of the MAYBE_ALLOC() macro. Haven't seen it
> resolved (but I disconnected shortly after that).

I just double checked, and that's been taken care of. (For those keeping score
at home, this macro is on the explore-wc branch in subversion/libsvn_wc/entries.c)

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1066748
Received on 2009-01-29 06:16:44 CET

This is an archived mail posted to the Subversion Dev mailing list.