[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r35439 - in trunk/subversion/bindings/swig: . python/libsvn_swig_py ruby/libsvn_swig_ruby

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Sat, 24 Jan 2009 00:17:04 +0100

> -----Original Message-----
> From: Hyrum K. Wright [mailto:hyrum_at_hyrumwright.org]
> Sent: Friday, January 23, 2009 10:26 PM
> To: svn_at_subversion.tigris.org
> Subject: svn commit: r35439 - in trunk/subversion/bindings/swig: .
> python/libsvn_swig_py ruby/libsvn_swig_ruby
>
> Author: hwright
> Date: Fri Jan 23 13:26:16 2009
> New Revision: 35439
>
> Log:
> Fix the swig bindings after r35424.
>
> * subversion/bindings/swig/core.i,
> subversion/bindings/swig/svn_wc.i,
> subversion/bindings/swig/svn_delta.i,
> subversion/bindings/swig/svn_fs.i:
> Include apr_md5.h in place of svn_md5.h.

If this breaks our build, it probably breaks third party tools too?

I like the idea of the public header cleanup, but I'm not sure if we can do
this without breaking third party code.

While it is not part of the ABI, the header files are certainly part of our
public API.

        Bert
>
> * subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c,
> subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c:
> Include svn_props.h.
>
> Modified:
> trunk/subversion/bindings/swig/core.i
> trunk/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
> trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
> trunk/subversion/bindings/swig/svn_delta.i
> trunk/subversion/bindings/swig/svn_fs.i
> trunk/subversion/bindings/swig/svn_wc.i
>
> Modified: trunk/subversion/bindings/swig/core.i
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/swig/core.i?
> pathrev=35439&r1=35438&r2=35439
> =======================================================================
> =======
> --- trunk/subversion/bindings/swig/core.i Fri Jan 23 13:00:45 2009
> (r35438)
> +++ trunk/subversion/bindings/swig/core.i Fri Jan 23 13:26:16 2009
> (r35439)
> @@ -32,7 +32,7 @@
> #include <apr.h>
> #include <apr_general.h>
>
> -#include "svn_md5.h"
> +#include <apr_md5.h>
> #include "svn_diff.h"
> #include "svn_private_config.h"
> %}
>
> Modified:
> trunk/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/swig/python/
> libsvn_swig_py/swigutil_py.c?pathrev=35439&r1=35438&r2=35439
> =======================================================================
> =======
> --- trunk/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
> Fri Jan 23 13:00:45 2009 (r35438)
> +++ trunk/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
> Fri Jan 23 13:26:16 2009 (r35439)
> @@ -35,6 +35,7 @@
> #include "svn_opt.h"
> #include "svn_delta.h"
> #include "svn_auth.h"
> +#include "svn_props.h"
> #include "svn_pools.h"
> #include "svn_mergeinfo.h"
> #include "svn_types.h"
>
> Modified:
> trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/swig/ruby/li
> bsvn_swig_ruby/swigutil_rb.c?pathrev=35439&r1=35438&r2=35439
> =======================================================================
> =======
> --- trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
> Fri Jan 23 13:00:45 2009 (r35438)
> +++ trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
> Fri Jan 23 13:26:16 2009 (r35439)
> @@ -34,6 +34,7 @@
>
> #include "svn_nls.h"
> #include "svn_pools.h"
> +#include "svn_props.h"
> #include "svn_time.h"
> #include "svn_utf.h"
>
>
> Modified: trunk/subversion/bindings/swig/svn_delta.i
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/swig/svn_del
> ta.i?pathrev=35439&r1=35438&r2=35439
> =======================================================================
> =======
> --- trunk/subversion/bindings/swig/svn_delta.i Fri Jan 23 13:00:45
2009
> (r35438)
> +++ trunk/subversion/bindings/swig/svn_delta.i Fri Jan 23 13:26:16
2009
> (r35439)
> @@ -149,7 +149,7 @@ void svn_delta_wrap_window_handler(svn_t
> /* -------------------------------------------------------------------
> ---- */
>
> %{
> -#include "svn_md5.h"
> +#include <apr_md5.h>
> %}
>
> /* -------------------------------------------------------------------
> ----
>
> Modified: trunk/subversion/bindings/swig/svn_fs.i
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/swig/svn_fs.
> i?pathrev=35439&r1=35438&r2=35439
> =======================================================================
> =======
> --- trunk/subversion/bindings/swig/svn_fs.i Fri Jan 23 13:00:45 2009
> (r35438)
> +++ trunk/subversion/bindings/swig/svn_fs.i Fri Jan 23 13:26:16 2009
> (r35439)
> @@ -124,7 +124,7 @@ svn_fs_root_fs_wrapper(svn_fs_root_t *ro
> /* -------------------------------------------------------------------
> ---- */
>
> %{
> -#include "svn_md5.h"
> +#include <apr_md5.h>
> %}
>
> %include svn_fs_h.swg
>
> Modified: trunk/subversion/bindings/swig/svn_wc.i
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/swig/svn_wc.
> i?pathrev=35439&r1=35438&r2=35439
> =======================================================================
> =======
> --- trunk/subversion/bindings/swig/svn_wc.i Fri Jan 23 13:00:45 2009
> (r35438)
> +++ trunk/subversion/bindings/swig/svn_wc.i Fri Jan 23 13:26:16 2009
> (r35439)
> @@ -228,7 +228,7 @@
> /* -------------------------------------------------------------------
> ---- */
>
> %{
> -#include "svn_md5.h"
> +#include <apr_md5.h>
> %}
>
> %include svn_wc_h.swg
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageI
> d=1045390

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1045615
Received on 2009-01-24 00:17:23 CET

This is an archived mail posted to the Subversion Dev mailing list.