[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 3227 - adding some extra "custom" headers to the email

From: Jon Bendtsen <jbendtsen_at_laerdal.dk>
Date: Thu, 22 Jan 2009 11:36:40 +0100

On 22/01/2009, at 11.30, Greg Stein wrote:

> On Thu, Jan 22, 2009 at 11:03, Jon Bendtsen <jbendtsen_at_laerdal.dk>
> wrote:
>> ...
>> But what if people wants more than module, branch, submodule and
>> file.
>> What about directory and subdir, ...
>> Maybe we should add generic fields like
>> pf1, pf2, ... (Path Field 1, 2, ...)
> That is what I've been trying to describe. You can name each of the
> fields as corresponding to a particular path segment:
> headers_from_path = module/branch/submodule/directory/subdir/.../file

yes, but i wanted to add a twist. I didnt want to put the word 'branch'
in the header, i figured that a simple pfX could do it

>>>>> Because you defined the superclass to take that parameter. The
>>>>> MailedOutput.start() call is going to throw an exception because
>>>>> you
>>>>> don't pass the value.
>>>> I didnt experience exceptions or other faults on the ~25.000
>>>> changes
>>>> we had in our subversion repository. I started the script by "hand"
>>>> to
>>>> a dummy email address, and there was nothing on stdout or stderr.
>>> The exception would be raised if you use the smtp_hostname
>>> configuration option. I suspect you maybe used the mail_command
>>> configuration instead? Or maybe left both blank and generated to
>>> stdout instead?
>> i use mail_command. I can try using the smtp_hostname
> No need to try it. I know it will throw an exception. Just add that
> parameter like I pointed out, and it should work fine.

I still need to test that it works once i have added the parameter,
and for that i would like to see the change from before to after.


Received on 2009-01-22 11:55:41 CET

This is an archived mail posted to the Subversion Dev mailing list.