Re: [PATCH] fix for incorrect/missing mail headers in commit-email.pl

On Jan 21, 2009, at 21:09 , Greg Stein wrote:

> Yup. Could get to be quite slow, re-reading the repository each time
> to generate the email. Not to mention that commit-email forks off
> svnlook for its operation rather than binding to the libraries.

Another reason to change this.

> If you want to maintain confidentiality, then I believe that you could
> auto-generate N "groups" in the mailer.conf file, each with a
> different to_addr value. mailer.py will then deliver one message per
> group, each addressed to a single person. The changeset will be
> computed once, although it will re-execute the diff logic for each
> message.

Ok, thanks for the tip! I'll add it to the bug tracking ticket.

> Well... you could construct a .conf file on-the-fly in /tmp, run
> mailer.py, and then remove the file.

Oh yeah, thought about that option too, but forgot to include it in my
email. I don't like temporary files either, too much hassle to do it
safe and correctly. I'll probably go for the one-mailer-conf-per-
repository-with-N-groups then.

Regards,
Michiel

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1041083
Received on 2009-01-21 14:43:58 CET