[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35314 - in trunk/subversion: include include/private libsvn_auth_gnome_keyring libsvn_subr

From: Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA_at_GMail.Com>
Date: Wed, 21 Jan 2009 12:02:03 +0100

2009-01-21 10:12 Greg Stein <gstein_at_gmail.com> napisaƂ(a):
> On Sun, Jan 18, 2009 at 18:55, Arfrever Frehtes Taifersar Arahesis
> <Arfrever.FTA_at_gmail.com> wrote:
>> Author: arfrever
>> Date: Sun Jan 18 09:55:07 2009
>> New Revision: 35314
>>
>> Log:
>> Rename svn_auth_unlock_prompt_func_t to
>> svn_auth_gnome_keyring_unlock_prompt_func_t.
>> Rename svn_cmdline_auth_unlock_prompt() to
>> svn_cmdline__auth_gnome_keyring_unlock_prompt().
>
> Why? I don't know why this was done, either from mailing list traffic
> (missed it?) or from this log message. This message just says what was
> done, but with no rationale given for _why_.

These types/functions are specific to GNOME Keyring providers.
For example svn_cmdline_auth_unlock_prompt() was printing
"Password for [%s] GNOME keyring: ".

>>...
>> +++ trunk/subversion/include/svn_auth.h Sun Jan 18 09:55:07 2009 (r35314)
>>...
>> @@ -945,24 +925,46 @@ svn_auth_get_keychain_ssl_client_cert_pw
>> #endif /* DARWIN || DOXYGEN */
>>
>> #if (!defined(DARWIN) && !defined(WIN32)) || defined(DOXYGEN)
>
> I thought these crazy #if lines were supposed to be fixed?

What is wrong with these lines?
GNOME Keyring / KWallet providers aren't available on Mac OS / Windows.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1040863
Received on 2009-01-21 12:04:12 CET

This is an archived mail posted to the Subversion Dev mailing list.