[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] calling diff_summarize from SVN Perl bindings

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Mon, 19 Jan 2009 13:10:33 -0600

Daniel Shahaf wrote:
> Julian Foad wrote on Mon, 19 Jan 2009 at 09:03 -0000:
>> Daniel Shahaf wrote:
>>> Please wait a little bit more than just one weekend before deciding your
>>> patch was ignored. :-)
>>>
>>>
>>> Also, a couple of stylistic bugs while I'm here:
>>>
>>> * Please write patches against trunk. (And if not against trunk, do
>>> indicate that at the time you post them.)
>>>
>>> * Use spaces, not tabs.
>>>
>>>
>>> Thanks for the patch,
>> Daniel, it may not be clear to James whether you require him to fix
>> those things before his patch will be accepted.
>>
>
> Good point. @James: yes, please verify that the patch still applies and
> to trunk works as intended. (I see that you have already fixed the tabs
> issue.)
>
> Also, for next time, it's better to send patches using a text/* MIME type,
> rather than 'application/octet-stream' as you did. (Sometimes, naming the
> patch file with a '.txt' extension causes 'text/plain' to be used.)

One more suggestion: include a log message. From HACKING: "Please include a log
message with your patch. A good log message helps potential reviewers understand
the changes in your patch, and increases the likelihood that it will be
applied." You can find the log message guidelines here:
http://subversion.tigris.org/hacking.html#log-messages

-Hyrum

PS - Please don't feel like we're trying to emphasis process over substance.
That's not the point! We've just discovered over the years that these processes
help improve the quality of the software, and that encouraging new contributors
to follow them early on creates better maintainers in the future. Thanks for
the patches!

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1035427
Received on 2009-01-19 20:11:18 CET

This is an archived mail posted to the Subversion Dev mailing list.