[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35164 - trunk/subversion/libsvn_subr

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Mon, 12 Jan 2009 15:58:20 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Julian,

Julian Foad wrote:
> This fix is good. Thank you.
>
> I have just a meta-comment about describing changes like this one:
>
> "Suppressing" is like "hiding" or "turning off". Remember that the
> reason we are adding "const" is to fix the problem that the compiler
> pointed out, not just to stop the compiler issuing the message. It would
> be the right thing to do even if the compiler had not issued the
> message, or if the compiler was still issuing the message (for whatever
> reason) after the change.
>
> So, when we fix a problem and that stops the compiler issuing a warning,
> we should say "We've fixed this problem (which the compiler pointed
> out)" rather than "We've stopped the compiler issuing a warning."

Thanks for pointing it out. In future I shall see to it that, the log message
is phrased properly.

> In this case, I might write:
> [[[
> Follow up r35156. Add "const" to an input pointer parameter. (Found by a
> compiler warning.)
>
> ...
> ]]]
>
> There is no need to edit this log message: there are already lots like
> it; and this is not directed at you in particular: I'm just using this
> log message as an example.

Though you said the above, I ve corrected the specific log message, since it
does not hurt :)

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFJaxtC9o1G+2zNQDgRAszmAKCN76Ezl5XO0vkXGRBnUiAefIOU1ACeLPkj
8r1opFOdjbp0DdZhJXcIbNE=
=iSEi
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1018752
Received on 2009-01-12 11:28:40 CET

This is an archived mail posted to the Subversion Dev mailing list.