[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn log taking multiple revision arguments

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Wed, 07 Jan 2009 14:49:42 -0800

Justin Erenkrantz wrote:
> On Wed, Jan 7, 2009 at 2:03 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>> Justin Erenkrantz wrote:
>>> - How can we support limit - as currently implemented, limit is
>>> handled by the RA layer, so...uh...
>> Could you add (inside the svn_client_log() logic) a simple intermediate
>> log-entry-callback wrapper that decrements a "global" limit and then passes
>> the return log entry off to the one provided to the svn_client_log() API?
>> Basically, the code would be counting the number of entries returned, which
>> would then affect the limit passed to the next iteration of svn_ra_get_log().
>
> That's the cop-out, but, yah, we could do that instead of revving the
> RA APIs. Anyone feel strongly here? -- justin

Not a strong feeling, but I prefer the wrapper in place of revving the API, but
that's my comment from the peanut gallery. :)

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1010605
Received on 2009-01-07 23:50:02 CET

This is an archived mail posted to the Subversion Dev mailing list.