[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: packing race condition

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Tue, 06 Jan 2009 09:08:46 -0600

Daniel Shahaf wrote:
>>>> Added the use of the write lock in r35031.
> ...
>> Do you need acquire_fs_mutex()?
>
> Ping? From reading fs-loader.c it seems to me that acquire_fs_mutex()
> is only needed when common_pool is used. But svn_fs_pack() doesn't use
> common_pool. Hence my question.
>
> (i.e., I'm not saying it's wrong the way it is; I'm only saying that I
> don't see why *not* acquiring that mutex would be wrong.)

I'm not sure. I simply emulated what I saw for upgrade. It sounds like you
know more about this than I do. :)

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1007696
Received on 2009-01-06 16:09:09 CET

This is an archived mail posted to the Subversion Dev mailing list.