[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35023 - trunk/subversion/libsvn_fs_fs

From: Stefan Sperling <stsp_at_elego.de>
Date: Sun, 4 Jan 2009 14:39:42 +0100

On Sun, Jan 04, 2009 at 09:07:01AM +0200, Daniel Shahaf wrote:
> > > @@ -180,6 +190,8 @@ path_rev_packed(svn_fs_t *fs, svn_revnum
> > > fs_fs_data_t *ffd = fs->fsap_data;
> > > assert(ffd->max_files_per_dir);
> > > + assert(is_packed_rev(fs, rev));
> >
> > We're not using assert() anymore, but SVN_ASSERT(), assuming the method
> > returns an svn_error_t *.
> >
>
> It returns const char *.

You could probably use SVN_ERR_ASSERT_NO_RETURN() in this case.
It was made for functions that do not return svn_error_t*.

But assert()s do not get compiled into release builds anyway.
It's aborts() which are really bad when used outside of the
SVN_ERR_ASSERT* macros.

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1002959
Received on 2009-01-04 14:40:23 CET

This is an archived mail posted to the Subversion Dev mailing list.