Re: SQLite and the Ruby bindings tests on Windows

Hi kou

On Mon, Dec 15, 2008 at 7:45 PM, Joe Swatosh <joe.swatosh_at_gmail.com> wrote:
> Hi kou,
>
> On Mon, Dec 15, 2008 at 6:30 AM, Kouhei Sutou <kou_at_cozmixng.org> wrote:
>> Hi,
>>
>> In <ae6cb1100812142233n4920e50fufe2095e083948150_at_mail.gmail.com>
>> "Re: SQLite and the Ruby bindings tests on Windows" on Sun, 14 Dec 2008 22:33:03 -0800,
>> Joe Swatosh <joe.swatosh_at_gmail.com> wrote:
>>
>>> > What about adding Svn::Client::Context#close and
>>> > Svn::Client::Context#initialize accepts a block?
>>> >
>>> > pseudo code:
>>> > class Svn::Client::Context
>>> > def initialize(...)
>>> > ...
>>> > return unless block_given?
>>> > begin
>>> > yield(self)
>>> > ensure
>>> > close
>>> > end
>>> > end
>>> >
>>> > def close
>>> > @pool.destroy
>>> > end
>>> > end
>>> >
>>> > But I'm not sure that 'close' is a good name for that...
>>> >
>>>
>>> Based on the above idea, I committed r34708. Instead of Context#initialize
>>> taking a block I modified SvnTestUtil#make_context to take a block. I think
>>> that worked better for updating the tests, but I'd like to see the
>>> Context#initialize take a block someday.
>>
>> I think of an idea that 'destroy' is more better name rather
>> than 'close'. What about this? The attached patch includes
>> block supported #initialize.
>>
>
> With your patch I get:
> Loaded suite .
> Started
> EEEEEEEEEEEEE.EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE.E..............................................EEE..........EEEEEEEE..EE.EE
> EEEEEEEEE.EEEE.......EEEEEEE.E.EEEEEEE...E.EEE.EEEE......E.EEEEEEEEEE.EEE..
> Finished in 695.42 seconds.
>

Okay, I had a boneheaded config problem. Here are the results of take
2 (less a couple tests that still used #close):

************************************************************************
test/run-test.rb test/test_client.rb -n test_merge
Loaded suite test_client.rb
Started
E
Finished in 7.042 seconds.

  1) Error:
test_merge(SvnClientTest):
Svn::Error::WcFoundConflict:
D:\SVN\src-trunk\subversion\libsvn_client\commit_util.c:289:
Svn::Error::WcFoundConflict: Aborting commit:
'D:\SVN\src-trunk\subversion\bind
ings\swig\ruby\wc-tmp\wc\trunk\sample.txt' remains in conflict
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`svn_client_commit4'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in `commit4'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/client.rb:166:in `commit'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:1016:in
`assert_merge'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/util.rb:181:in
`make_context'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:937:in
`assert_merge'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:1040:in
`test_merge'

1 tests, 10 assertions, 0 failures, 1 errors
************************************************************************
test/run-test.rb test/test_client.rb -n test_merge_peg
Loaded suite test_client.rb
Started
E
Finished in 6.083 seconds.

  1) Error:
test_merge_peg(SvnClientTest):
Svn::Error::WcFoundConflict:
D:\SVN\src-trunk\subversion\libsvn_client\commit_util.c:289:
Svn::Error::WcFoundConflict: Aborting commit:
'D:\SVN\src-trunk\subversion\bind
ings\swig\ruby\wc-tmp\wc\trunk\sample.txt' remains in conflict
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`svn_client_commit4'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in `commit4'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/client.rb:166:in `commit'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:1016:in
`assert_merge'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/util.rb:181:in
`make_context'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:937:in
`assert_merge'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:1046:in
`test_merge_peg'

1 tests, 10 assertions, 0 failures, 1 errors
************************************************************************
test/run-test.rb test/test_client.rb -n test_set_revision_by_date
Loaded suite test_client.rb
Started
E
Finished in 6.842 seconds.

  1) Error:
test_set_revision_by_date(SvnClientTest):
Svn::Error::ClientUnrelatedResources:
D:\SVN\src-trunk\subversion\libsvn_client\ra.c:702:
Svn::Error::ClientUnrelatedResources: Unable to fi
nd repository location for
'file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/hello.txt'
in revision 0
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`svn_client_cat2'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in `cat2'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/client.rb:404:in `cat'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2339:in
`test_set_revision_by_date'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/util.rb:181:in
`make_context'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2328:in
`test_set_revision_by_date'

1 tests, 0 assertions, 0 failures, 1 errors
************************************************************************
test/run-test.rb test/test_client.rb -n test_username_provider
Loaded suite test_client.rb
Started
F
Finished in 5.884 seconds.

  1) Failure:
test_username_provider(SvnClientTest)
[D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2099]:
<Svn::Error::ReposHookFailure> exception expected but was
Class: <ArgumentError>
Message: <"invalid type: Bignum">
---Backtrace---
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`svn_client_revprop_set'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in `revprop_set'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/client.rb:543:in
`revprop_set'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2100:in
`test_username_provider'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2099:in
`test_username_provider'
---------------

1 tests, 2 assertions, 1 failures, 0 errors
************************************************************************
test/run-test.rb test/test_client.rb -n test_windows_simple_provider
Loaded suite test_client.rb
Started

Finished in 0.0 seconds.

0 tests, 0 assertions, 0 failures, 0 errors
************************************************************************
test/run-test.rb test/test_fs.rb -n test_transaction
Loaded suite test_fs.rb
Started

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86: [BUG]
Segmentation fault
ruby 1.8.6 (2007-03-13) [i386-mswin32]

************************************************************************
test/run-test.rb test/test_repos.rb -n test_hotcopy
Loaded suite test_repos.rb
Started
E
Finished in 2.602 seconds.

  1) Error:
test_hotcopy(SvnReposTest):
Errno::EACCES: Permission denied - repos or tmp/back
D:/Ruby186/lib/ruby/1.8/fileutils.rb:505:in `rename'
D:/Ruby186/lib/ruby/1.8/fileutils.rb:505:in `mv'
D:/Ruby186/lib/ruby/1.8/fileutils.rb:1395:in `fu_each_src_dest'
D:/Ruby186/lib/ruby/1.8/fileutils.rb:1411:in `fu_each_src_dest0'
D:/Ruby186/lib/ruby/1.8/fileutils.rb:1393:in `fu_each_src_dest'
D:/Ruby186/lib/ruby/1.8/fileutils.rb:494:in `mv'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_repos.rb:216:in
`test_hotcopy'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/util.rb:181:in
`make_context'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_repos.rb:201:in
`test_hotcopy'

1 tests, 1 assertions, 0 failures, 1 errors
************************************************************************
test/run-test.rb test/test_wc.rb -n test_entry
Loaded suite test_wc.rb
Started
F
Finished in 1.785 seconds.

  1) Failure:
test_entry(SvnWcTest)
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_wc.rb:203:in
`test_entry'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/wc.rb:117:in `_open'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/wc.rb:95:in `open'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_wc.rb:192:in
`test_entry'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/util.rb:181:in
`make_context'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_wc.rb:186:in
`test_entry':
<false> is not true.

1 tests, 5 assertions, 1 failures, 0 errors
************************************************************************
test/run-test.rb test/test_wc.rb -n test_relocate
Loaded suite test_wc.rb
Started
F
Finished in 2.678 seconds.

  1) Failure:
test_relocate(SvnWcTest)
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_wc.rb:1002:in
`test_relocate'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/wc.rb:117:in `_open'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/wc.rb:101:in `probe_open'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_wc.rb:989:in
`test_relocate'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/ra.rb:33:in `open'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_wc.rb:977:in
`test_relocate'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/util.rb:181:in
`make_context'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_wc.rb:974:in
`test_relocate':
<[["12ea925a-270b-1041-9d6a-6dce1087985f",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2",
  nil],
 ["12ea925a-270b-1041-9d6a-6dce1087985f",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2"],
 [nil,
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2/dir1",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2"],
 [nil,
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2/dir1/hello.txt",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2"],
 [nil,
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2/dir2",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2"],
 [nil,
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2/dir2/hello2.txt",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2"]]>
expected but was
<[["12ea925a-270b-1041-9d6a-6dce1087985f",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2",
  nil],
 ["12ea925a-270b-1041-9d6a-6dce1087985f",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2"],
 ["12ea925a-270b-1041-9d6a-6dce1087985f",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2/dir1",
  nil],
 ["12ea925a-270b-1041-9d6a-6dce1087985f",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2/dir1",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2"],
 ["12ea925a-270b-1041-9d6a-6dce1087985f",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2/dir1/hello.txt",
  nil],
 ["12ea925a-270b-1041-9d6a-6dce1087985f",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2/dir1/hello.txt",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2"],
 ["12ea925a-270b-1041-9d6a-6dce1087985f",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2/dir2",
  nil],
 ["12ea925a-270b-1041-9d6a-6dce1087985f",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2/dir2",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2"],
 ["12ea925a-270b-1041-9d6a-6dce1087985f",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2/dir2/hello2.txt",
  nil],
 ["12ea925a-270b-1041-9d6a-6dce1087985f",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2/dir2/hello2.txt",
  "file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/dir2"]]>.

1 tests, 2 assertions, 1 failures, 0 errors

So it looks pretty good. We have the merge tests and test_relocate in
common, I'll look
at my other failures before those. First, I'm going to try to figure
out the access violation.

Sorry for the initial foul up.

--
Joe
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=985498