[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Should svn_fs_fs__noderev_same_rep_key() accept NULL representation_t::uniquifier?

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 15 Dec 2008 21:51:43 +0000

On Mon, 2008-12-15 at 12:25 -0600, Hyrum K. Wright wrote:
> Julian Foad wrote:
> > (And, for brevity, the comparison of the whole representation_t pointers
> > 'a' and 'b' could use this form too:
> >
> > Index: subversion/libsvn_fs_fs/fs_fs.c
> > ===================================================================
> > --- subversion/libsvn_fs_fs/fs_fs.c (revision 34710)
> > +++ subversion/libsvn_fs_fs/fs_fs.c (working copy)
> > @@ -3423,10 +3423,7 @@
> > if (a == b)
> > return TRUE;
> >
> > - if (a && (! b))
> > - return FALSE;
> > -
> > - if (b && (! a))
> > + if (a == NULL || b == NULL)
> > return FALSE;
> >
> > if (a->offset != b->offset)
> > )
>
> Kou,
> Could you commit the changes to fs_fs.c?

No need for Kou to bother with my trivial suggestion. I did it in
r34721.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=984677
Received on 2008-12-15 22:52:06 CET

This is an archived mail posted to the Subversion Dev mailing list.