[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34527 - trunk/subversion/libsvn_fs_fs

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: Tue, 2 Dec 2008 10:21:26 -0800

On Tue, Dec 2, 2008 at 10:13 AM, Hyrum Wright <hyrum_at_hyrumwright.org> wrote:
> Author: hwright
> Date: Tue Dec 2 10:13:50 2008
> New Revision: 34527
>
> Log:
> * subversion/libsvn_fs_fs/caching.c
> (svn_fs_fs__initialize_caches): Followup to r34510: Improve comment.
>
> Suggested by: julianfoad
>
> Modified:
> trunk/subversion/libsvn_fs_fs/caching.c
>
> Modified: trunk/subversion/libsvn_fs_fs/caching.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_fs/caching.c?pathrev=34527&r1=34526&r2=34527
> ==============================================================================
> --- trunk/subversion/libsvn_fs_fs/caching.c Tue Dec 2 09:51:23 2008 (r34526)
> +++ trunk/subversion/libsvn_fs_fs/caching.c Tue Dec 2 10:13:50 2008 (r34527)
> @@ -260,7 +260,8 @@ svn_fs_fs__initialize_caches(svn_fs_t *f
> SVN_ERR(svn_cache__set_error_handler(ffd->dir_cache,
> warn_on_cache_errors, fs, pool));
>
> - /* Only 16 bytes per entry (a revision number + the corresponding offset). */
> + /* Only 16 bytes per entry (a revision number + the corresponding offset).
> + Since we want ~8k pages, that means 512 entries per page. */

Didn't glasser say that the 8k pages correspond to the minimum APR
pool size? Mentioning that would really disspell the magic... ;-)

> if (memcache)
> SVN_ERR(svn_cache__create_memcache(&(ffd->packed_offset_cache),
> memcache,
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=728398
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=728404
Received on 2008-12-02 19:21:44 CET

This is an archived mail posted to the Subversion Dev mailing list.