[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Problem introduced in revision 34378 of libsvn_fs_fs/fs_fs.c?

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Wed, 26 Nov 2008 11:28:53 -0600

Marc Haesen wrote:
> I am talking about the test added in commit 34388 of fs_fs.c.
>
> What you see is that the sha1 checksum is written out in
> representation_string(...) when the format of the repository is less
> then SVN_FS_FS__MIN_REP_SHARING_FORMAT. But I think that the sha1
> checksum should be written when the format is higher or equal.

You are correct; I inadvertently switched the conditional in r34388. I'm in the
midst of testing the fix, and will commit it shortly. I think this may also be
the reason r34398 was required, and I'm also testing this.

Thanks for the sharp eyes!

-Hyrum

Received on 2008-11-26 18:29:11 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.