[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34340 - trunk/subversion/libsvn_fs_fs

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 22 Nov 2008 22:26:54 +0200 (Jerusalem Standard Time)

hwright_at_tigris.org wrote on Sat, 22 Nov 2008 at 12:11 -0800:
> Author: hwright
> Date: Sat Nov 22 12:11:58 2008
> New Revision: 34340
>

> Modified: trunk/subversion/libsvn_fs_fs/tree.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_fs/tree.c?pathrev=34340&r1=34339&r2=34340
> ==============================================================================
> --- trunk/subversion/libsvn_fs_fs/tree.c Sat Nov 22 12:02:51 2008 (r34339)
> +++ trunk/subversion/libsvn_fs_fs/tree.c Sat Nov 22 12:11:58 2008 (r34340)
> @@ -2268,7 +2268,7 @@ fs_file_checksum(svn_checksum_t **checks
> svn_checksum_t *file_checksum;
>
> SVN_ERR(get_dag(&file, root, path, pool));
> - SVN_ERR(svn_fs_fs__dag_file_checksum(&file_checksum, file, pool));
> + SVN_ERR(svn_fs_fs__dag_file_checksum(&file_checksum, file, kind, pool));
> *checksum = (file_checksum->kind == kind) ? file_checksum : NULL;

You don't check if file_checksum is NULL before dereferencing it.

> return SVN_NO_ERROR;
> }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-22 21:27:30 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.