On Sun, Nov 16, 2008 at 05:36:48PM +0000, Stefan Sperling wrote:
> On Sun, Nov 16, 2008 at 05:53:20PM +0100, Jens Seidel wrote:
> > On Sat, Nov 15, 2008 at 09:27:57PM +0100, Arfrever Frehtes Taifersar Arahesis wrote:
> > > 2008-10-28 17:14:39 Jens Seidel napisa??(a):
> > > > On Tue, Oct 21, 2008 at 02:30:08PM +0200, Jens Seidel wrote:
> > > > > there seems again a problem if the URL of a repository is like
> > > > > svn+ssh://svn@10.0.1.1. I'm using trunk, r33797.
> >
> > Checking out a repository again with current trunk fails now (but at least
> > doesn't crash) :-(
> >
> > $ svn cleanup
> >
> > Program received signal SIGSEGV, Segmentation fault.
> > [Switching to Thread 47116375701120 (LWP 8732)]
> > 0x00002ada2100e056 in svn_uri_is_canonical (
> > uri=0x6653b0 "svn+ssh://svn@10.0.1.1")
> > at subversion/libsvn_subr/dirent_uri.c:1029
> > 1029 while (*ptr != '/')
>
> >From reading the code, it looks like we are running over the end
> of that string into uninitialised memory.
Could it really so simple? Considering some error messages I thought
bogus metadata was written into .svn/.
> Jens, can you try this patch?
>
> Index: subversion/libsvn_subr/dirent_uri.c
> /* Found a hostname, check that it's all lowercase. */
> ptr = seg;
> - while (*ptr != '/')
> + while (*ptr && *ptr != '/')
Yep, this seems indeed to fix all related issues I noticed. Thanks a lot!
Jens
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-16 20:07:29 CET