[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33872 - trunk/tools/dev

From: Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com>
Date: Sat, 15 Nov 2008 21:21:56 +0100

2008-10-23 23:54:17 hwright_at_tigris.org napisaƂ(a):
> Author: hwright
> Date: Thu Oct 23 14:54:17 2008
> New Revision: 33872
>
> Log:
> Include patches committed by partial committers in the contribulyzer. As
> partial committers grow in the project, they usually commit their own patches
> following a +1 from a full committer. Those patches required a 'Patch by' line
> to show up on the contribulyzer, and this commit fixes that.

Could you change contribulyze.py to include only patches which were committed
outside of partial commiters' commit area?
You can check for existence of 'Approved by:' line.

> * tools/dev/contribulyze.py
> (graze): If no 'Patch by' is explicitly given, assume the committer is the
> author of the patch.
>
> Modified:
> trunk/tools/dev/contribulyze.py
>
> Modified: trunk/tools/dev/contribulyze.py
> URL: http://svn.collab.net/viewvc/svn/trunk/tools/dev/contribulyze.py?pathrev=33872&r1=33871&r2=33872
> ==============================================================================
> --- trunk/tools/dev/contribulyze.py Thu Oct 23 14:21:00 2008 (r33871)
> +++ trunk/tools/dev/contribulyze.py Thu Oct 23 14:54:17 2008 (r33872)
> @@ -545,6 +545,7 @@ def graze(input):
> log = LogMessage(m.group(1), m.group(2), m.group(3))
> num_lines = int(m.group(4))
> just_saw_separator = False
> + saw_patch = False
> line = input.readline()
> # Handle 'svn log -v' by waiting for the blank line.
> while line != '\n':
> @@ -574,6 +575,8 @@ def graze(input):
> user = log.committer
> c = Contributor.get(user, real, email)
> c.add_activity(field.name, log)
> + if (field.name == 'Patch'):
> + saw_patch = True
> field.add_contributor(c)
> line = input.readline()
> if line == log_separator:
> @@ -596,6 +599,9 @@ def graze(input):
> log.add_field(field)
> field = None
> num_lines -= 1
> + if not saw_patch and log.committer != '(no author)':
> + c = Contributor.get(log.committer, None, None)
> + c.add_activity('Patch', log)
> continue
>
> index_introduction = '''
>

-- 
Arfrever Frehtes Taifersar Arahesis

Received on 2008-11-15 21:26:42 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.