[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Diffs in log messages [was: svn commit: propchange - r34067 - svn:log]

From: Neels J. Hofmeyr <neels_at_elego.de>
Date: Fri, 07 Nov 2008 00:09:25 +0100

Julian Foad wrote:
> On Wed, 2008-11-05 at 12:10 -0800, Greg Stein wrote:
>> Seriously... are we going to have to install a pre-commit hook to fail
>> if people keep inserting diffs into the log message?
>
> Maybe it's only me that keeps inserting diffs in the log message. I'll
> keep an eye open for ways to change my working practices to avoid this,
> but I can't see it's very likely at this point. At the moment I normally
> keep patches (with log message and diff) until ready to commit, and then
> try to remember to delete the diff and use the file as the log message
> with "svn ci -F/--file FILE".

Hm, I just keep a separate "log" file in each working copy root. It's handy
for me to have two separate vims open on the diff and the log message, much
easier copy-pasting of file/function names via Shift-middle-mouse-button.

Has someone actually come up with a script to automatically print a log
message skeleton with all files and function names in it? Would be nice to
save us that copy-paste orgy each time we commit.

~Neels

 I should get around to trying SVK some
> time. I need local commits!
>
> Or Perforce "changelist" feature that stores both a list of what files
> I'm working on and the log message that goes with them.
>
> - Julian
>
>
>> On Wed, Nov 5, 2008 at 12:08 PM, <gstein_at_tigris.org> wrote:
>>> Author: gstein
>>> Revision: 34067
>>> Property Name: svn:log
>>> Action: modified
>>>
>>> Property diff:
>>> --- old property value
>>> +++ new property value
>>> @@ -38,243 +38,3 @@ Make the tree conflicts WC API more cons
>>> * subversion/libsvn_wc/update_editor.c
>>> (check_tree_conflict): Adjust calls accordingly.
>>> (add_file): Adjust commented-out code accordingly.
>>> -
>>> -Index: subversion/include/svn_wc.h
>>> -===================================================================
>>> ---- subversion/include/svn_wc.h (revision 34061)
>>> -+++ subversion/include/svn_wc.h (working copy)
>>> -@@ -5278,17 +5278,16 @@ svn_wc_get_tree_conflict(svn_wc_conflict
>>> - svn_wc_adm_access_t *adm_access,
>>> - apr_pool_t *pool);
>>> -
>>> --/**
>>> -- * Add the tree conflict described by @a conflict to the directory entry
>>> -- * belonging to @a adm_access.
>>> -- * Do all allocations in @a pool.
>>> -+/** Record the tree conflict described by @a conflict in the WC.
>>> -+ * @a adm_access must be a write-access baton for the parent directory of
>>> -+ * @a victim->path. Use @a pool for all allocations.
>>> - *
> [...]
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org
>

Received on 2008-11-07 00:09:46 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.