[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: mod_dav_svn build?

From: Jan Nijtmans <nijtmans_at_tigris.org>
Date: Fri, 24 Oct 2008 09:56:54 +0200

2008/10/24 Daniel Shahaf <d.s_at_daniel.shahaf.name>:
> Neels J. Hofmeyr wrote on Fri, 24 Oct 2008 at 04:16 +0200:
>> No, I just keep poking, because there's a nice patch by a non-committer
>> that's also quite simple, and no-one with a mod_dav_svn build is willing or
>> able to just say whether it still compiles fine and has the desired effect.
>>
>
> It probably does.
>
> The reason I haven't committed it (although it *does* seem trivial, and
> although I do have a mod_dav_svn build env) is that it's right in the
> middle of code I don't know at all. In particular I don't know how
> whether the patch will have other (undesirable) effects.
>
> If someone familiar with the code agrees that the patch won't have any
> unexpected effects, I'll happily try the patch and commit it.

Well, I'm a little familiar with the code (because I studied it to create
this patch ...).

I applied this patch in an earlier 1.4 version of SVN, and it worked fine.
It just adds the ".." link in one additional situation: when there is
a replository list. I cannot imagine what unexpected side-effects that
could have.

So, please commit it, and just revoke my commit rights when it
doesn't work (oh, I don't have that ...., otherwise I would have
committed it myself). :-)

Neels J. Hofmeyr wrote on Fri, 24 Oct 2008 at 04:16 +0200:
> No, I just keep poking, because there's a nice patch by a non-committer

Thank you, Neels, for the compliment!

Regards,
          Jan Nijtmans

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-24 09:57:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.