Re: Reporting internal errors [was: svn commit: r33792 - in trunk/subversion: libsvn_wc svn]

On Wed, Oct 22, 2008 at 01:15:02PM +0100, Julian Foad wrote:
> On Tue, 2008-10-21 at 17:48 +0200, Jens Seidel wrote:
> > Nevertheless the intention should be to also display a proper localized
> > but more general error message if a very rare event happened (such as
[snip]

> > something like
> >
> > "An internal error occurred:
> > Either your repository or filesystem is corrupted or you found a bug.
> > If you suspect a bug, please send us the following error message:
> > "Value kjadfk72 ..."
> > "
> >
> > would be great.
>
> Yes. That is a very good suggestion for how to report internal errors
> and suspected data corruptions. This can be useful if the detailed
> message contains enough information to be more useful than simply a
> source flie name and line number would be.

Thanks.

> I chose to fix the particular messages that started this discussion in a
> different way in r33835, by replacing them with simple
> SVN_ERR_ASSERT/SVN_ERR_MALFUNCTION macros.

Yep, I have seen this already. I thought about an assert-like statement
when I wrote above.

> I committed your "U_" macro patch in r33836, and we can see if it
> becomes useful in practice.

If it isn't useful currently than there is no need to commit it :-)

Nevertheless I like your cleanup. It would be great if I (and others)
could save some time avoiding translating too many error messages.

Jens

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-22 15:02:08 CEST