[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Reporting internal errors [was: svn commit: r33792 - in trunk/subversion: libsvn_wc svn]

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 22 Oct 2008 13:15:02 +0100

On Tue, 2008-10-21 at 17:48 +0200, Jens Seidel wrote:
> let me add a note that I generally support translatable messages and
> this is also true for error messages. But if there is really no
> (real) possibility to see such an message it is just wasted time to
> translate it.
>
> Nevertheless the intention should be to also display a proper localized
> but more general error message if a very rare event happened (such as
> a database corruption). I'm not sure whether this happens currently
> or whether the user is confused with a very technical message.
>
> So instead of just printing
>
> "Value kjadfk72 in structure lahflh2 has value 27468 but not 27826 or 262"

Ha! Yes, that is what some of our error messages look like to a user.

> something like
>
> "An internal error occurred:
> Either your repository or filesystem is corrupted or you found a bug.
> If you suspect a bug, please send us the following error message:
> "Value kjadfk72 ..."
> "
>
> would be great.

Yes. That is a very good suggestion for how to report internal errors
and suspected data corruptions. This can be useful if the detailed
message contains enough information to be more useful than simply a
source flie name and line number would be.

I chose to fix the particular messages that started this discussion in a
different way in r33835, by replacing them with simple
SVN_ERR_ASSERT/SVN_ERR_MALFUNCTION macros.

I committed your "U_" macro patch in r33836, and we can see if it
becomes useful in practice.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-22 14:15:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.