[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33612 - in trunk: . subversion/tests/libsvn_delta

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 13 Oct 2008 07:00:14 -0700

On Mon, Oct 13, 2008 at 6:42 AM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
>...
>> * subversion/tests/libsvn_delta:
>> (svn:ignore): ignore the new window-test executable
>
> (I prefer to see these with uppercase first letter.)

"these" refers to ... what?

>...
>> + /* Note: put these in data segment, not the stack */
>
> Why?
>
>> + static char source[109001];
>> + static char target[109001];

220k on the stack is a bit much, I think. The values are basically
const, but hard to initialize at compile time. I'll expand the docco
just a bit.

>...
>> + svn_checksum(&expected, svn_checksum_md5, target, 109000, pool);
>
> Needs SVN_ERR().

Good catch. Thx.

>...
>> + actual = svn_checksum_create(svn_checksum_md5, pool);
>> + actual->digest = svn_txdelta_md5_digest(txstream);
>> + printf(" actual: %s\n", svn_checksum_to_cstring(actual, pool));
>> +
>> + return SVN_NO_ERROR;
>
> Where is the strcmp() that compares the actual and expected checksums?

hehe... forgot it. I realized this a bit later :-P

Will add, along with the window checks that Joe had in his Ruby test.

Cheers,
-g

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-13 16:00:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.