[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] fix compile error with Visual Studio 2008 express edition

From: Bert Huijben <B.Huijben_at_competence.biz>
Date: Fri, 26 Sep 2008 10:03:37 +0200

> -----Original Message-----
> From: Branko Čibej [mailto:brane_at_xbc.nu]
> Sent: vrijdag 26 september 2008 9:15
> To: Bert Huijben
> Cc: 'masaru tsuchiyama'; dev_at_subversion.tigris.org
> Subject: Re: [PATCH] fix compile error with Visual Studio 2008 express
> edition
>
> Bert Huijben wrote:
> >> -----Original Message-----
> >> From: masaru tsuchiyama [mailto:m.tmatma_at_gmail.com]
> >> Sent: donderdag 25 september 2008 14:13
> >> To: dev_at_subversion.tigris.org
> >> Subject: [PATCH] fix compile error with Visual Studio 2008 express
> >> edition
> >>
> >> Hi
> >>
> >> The attached patch fixes compile error by Visual Studio 2008 express
> >> edition.
> >>
> >> [[[
> >> Fix compile error by Visual Studio 2008 Express Edition.
> >> winres.h is not available in it.
> >>
> >> * build/win32/svn.rc
> >> (): Include winresrc.h instead of winres.h
> >>
> >> ]]]
> >>
> >
> > Hi,
> >
> > I can confirm this and will commit the patch to trunk when I get home
> (and nobody applies it before I do)
> >
> > winres.h is a wrapper header from the MFC and/or ATL framework
> included with the more expensive Visual C++ versions. This wrapper
> includes winresrc.h for the real work.
> >
> > Thanks for supplying the patch,
> >
>
> Wouldn't you at least want to verify if this happens to work with,
> e.g.,
> VC6? I have this nagging feeling that it doesn't.

Who said I didn't check the history of this file before committing?

This file was added to the Windows SDK in 1990. (Either the 16 bit Windows 3.X days or the start of the NT product line; at least well before it was called platform SDK).

So it was probably part of Visual C++ 2.0 (The first 32 bit version) and every public platform SDK ever released, while we document in INSTALL that you should have

* A recent Windows SDK if you are using Visual Studio 6.
        You can get it from MSDN if you have it or from
        http://www.microsoft.com/msdownload/platformsdk/sdkupdate/ if you
        don't.

The only problem with this documentation is that newer platform SDK versions dropped support of Visual C++ 6.0, so you probably should get the Windows XP version of the SDK instead of any newer version.

        Bert
Received on 2008-09-26 10:03:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.