[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33254 - trunk/subversion/libsvn_subr

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Wed, 24 Sep 2008 10:38:02 +0200

Julian Foad wrote:
> On Tue, 2008-09-23 at 10:20 -0700, steveking_at_tigris.org wrote:
>> Author: steveking
>> Date: Tue Sep 23 10:20:15 2008
>> New Revision: 33254
>>
>> Log:
>> Prevent segfault when Windows paths with forward slashes are passed.
>>
>> * subversion/libsvn_subr/path.c
>> (svn_path_canonicalize): only treat the path as an URI if the hostname is
>> valid.
>
> I'm trying to understand this change. What is an example of a path that
> made it seg-fault? Do you know why it seg-faults on Windows but not un
> Linux?
>

I've tried to reproduce it with the example in Stefan's mail but it all
works fine here. This must be related to specific apr-util versions.

The commit does lack test cases in
subversion/tests/libsvn_subr/path-test.c, both for svn_path_canonicalize
and svn_path_is_canonical.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-24 10:38:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.