[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] [PATCH] Allow any Neon version from specified branches

From: Greg Stein <gstein_at_gmail.com>
Date: Sun, 21 Sep 2008 16:29:18 -0700

[please review the PATCH mail submission guidelines in hacking.html;
it was very difficult to review your patch as emailed]

I don't support this particular patch. It allows 0.27.0 and 0.27.1 to
be used, which have known regressions. I believe you could alter the
regex to 0.27.2 in order to fix that.

Conceptually, I also disagree with the patch, as you, danielsh, and I
discussed on IRC. In the past, we have had issues with Neon (with all
dependent libraries, actually). I prefer that we only allow known-good
libraries, rather than open it to "anything on this branch".

If downstream maintainers are feeling pain, then they can patch out
our known-good check (not recommended, obviously, but that is their
call).

Cheers,
-g

On Sun, Sep 21, 2008 at 3:06 PM, Arfrever Frehtes Taifersar Arahesis
<arfrever.fta_at_gmail.com> wrote:
> I would like to suggest to change Neon version check on Unix-like systems
> so that any version from specified branches be allowed.
>
> Currently Subversion downstream maintainers have to update NEON_ALLOWED_LIST
> after every new release of Neon (before new version of Subversion is
> released which usually contains updated NEON_ALLOWED_LIST).
>
> Neon version check on Windows (build/generator/gen_win.py) is more tolerant.
>
> [[[
> Allow any Neon version from specified branches.
>
> * build/ac-macros/neon.m4
> (SVN_LIB_NEON, SVN_NEON_CONFIG): Update Neon version checks.
>
> * configure.ac
> (NEON_ALLOWED_LIST): Update list.
> ]]]
>
> --
> Arfrever Frehtes Taifersar Arahesis
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-22 01:29:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.