[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2748: non-UTF-8 filenames in the repository

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 17 Sep 2008 17:55:41 +0300 (Jerusalem Daylight Time)

C. Michael Pilato wrote on Wed, 17 Sep 2008 at 10:44 -0400:
> Daniel Shahaf wrote:
> > (And I'll also fix the comments in svn_fs.h to say explicitly that
> > control characters aren't allowed; svn_path_check_valid() already
> > forbids them.)
>
> Hrm... control characters *are* allowed, though. What you see in svn_fs.h
> is the full set of requirements *by the FS layer* for its paths. UTF-8 with
> no 0-offset characters. That's the whole story. To add control characters
> to the blacklist now is a violation of the API contract. If that means that
> svn_path_check_valid() isn't the right function to use for this validation
> -- or that it needs a new boolean flag that toggles the checks for control
> characters -- so be it.
>

But, in this case, when *should* svn_path_check_valid() be used? Why
does it check for control characters -- which of its callers need this
check?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-17 16:55:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.