[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2748: non-UTF-8 filenames in the repository

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 17 Sep 2008 17:40:26 +0300 (Jerusalem Daylight Time)

C. Michael Pilato wrote on Wed, 17 Sep 2008 at 10:12 -0400:
> Daniel Shahaf wrote:
> > Patch for issue #2748 ("clients can create non UTF-8 filenames in the
> > repository"). It prevents non-UTF-8 paths from entering the repository,
> > but it doesn't affect existing files in existing repositories, svnsync,
> > or 'svnadmin load'.
> >
> > I'm running 'make check' now, and I'll commit later today or tomorrow if
> > I don't hear anything.
> >
> > Daniel
> >
> > [[[
> > Validate in libsvn_repos that paths added to the repository are valid UTF-8.
> > This fixes issue #2748.
>
> These validations (which are a good idea) belong in the lowest layer that
> dictates the requirement, in this case, the FS layer.
>
>

I hadn't noticed that requirement in FS (but found it now, in svn_fs.h).
I'll move the checks -- they should still affect only new files/directories,
as far as I can tell. (And I'll also fix the comments in svn_fs.h to say
explicitly that control characters aren't allowed; svn_path_check_valid()
already forbids them.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-17 16:41:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.