Stefan Sperling wrote:
> On Wed, Sep 10, 2008 at 08:01:12PM +0200, Lieven Govaerts wrote:
>> Stefan Küng wrote:
>>> Before I commit this, maybe someone likes to first review it:
>>> this patch initializes all struct members in the functions
>>> svn_wc_conflict_description_create_text() and
>>> Found this due to crashes in TSVN - it tried to access the merged_file
>>> member which had a non-NULL value but pointed to bogus memory.
>>> If nobody objects, I'll commit this in about an hour (shouldn't be much
>>> to object to IMHO).
>> Using apr_pcalloc has the same effect, but slightly easier for the eyes.
> Oops, good point, actually.
> Stefan (you, not me :), do you want to make a follow-up commit that
> uses apr_pcalloc() instead?
Will do. I'm currently running a rebuild and do some tests before I
commit the change.
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
Received on 2008-09-10 20:54:33 CEST