[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] initialize struct members

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Wed, 10 Sep 2008 20:01:12 +0200

Stefan Küng wrote:
> Hi,
>
> Before I commit this, maybe someone likes to first review it:
> this patch initializes all struct members in the functions
> svn_wc_conflict_description_create_text() and
> svn_wc_conflict_description_create_prop().
> Found this due to crashes in TSVN - it tried to access the merged_file
> member which had a non-NULL value but pointed to bogus memory.
>
> If nobody objects, I'll commit this in about an hour (shouldn't be much
> to object to IMHO).
>
Using apr_pcalloc has the same effect, but slightly easier for the eyes.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-10 20:01:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.