[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Double-XML escape bug in svn log --xml -v

From: <Jeffrey.Klein_at_priorityhealth.com>
Date: Tue, 9 Sep 2008 14:43:11 -0400

We just had a problem with the XML output of svn log -xml -v. When the copyfrom-path
contains an XML special character, it gets XML encoded twice:

<paths>
<path
   action="D">/project/Jeff's File</path>
<path
   copyfrom-path="/project/Jeff&amp;apos;s File"
   copyfrom-rev="47"
   action="A">/project/Dave's File</path>
</paths>
<msg>This is Dave's now.
</msg>

In svn/svn-log.c, log_entry_receiver_xml() calls svn_xml_escape_attr_cstring()
and passes the result to svn_xml_make_open_tag(), but that function already
escapes any attribute values.

Is this documented|known|desired behavior? If not, would fixing it break anything
else?

Thanks,
-Jeff

** ** ** PRIVILEGED AND CONFIDENTIAL ** ** **
This email transmission contains privileged and confidential information intended only for the use of the individual(s) or entity named above. Any unauthorized review, use, disclosure or distribution is prohibited and may be a violation of law. If you are not the intended recipient or a person responsible for delivering this message to an intended recipient, please delete the email and immediately notify the sender via the email return address or mailto:postmaster_at_priorityhealth.com. Thank you.


Received on 2008-09-09 22:05:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.